Introduce public preview SQL Database Agent .NET SDK by johnpaulkee · Pull Request #4340 · Azure/azure-sdk-for-net

johnpaulkee · 2018-05-18T03:33:55Z

Description

This is a preview SDK for the new SQL Database Agent introduced in the 2017-03-01 preview API version.
Added the corresponding tests. Pull request for Swagger: Azure/azure-rest-api-specs#2909

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…o grab subscription id from env variable

johnpaulkee · 2018-05-18T03:39:26Z

@jaredmoo Initial pass at the SQL Database Agent .NET SDK PR is set up.

jaredmoo

Please also bump version (latest published is 1.15.0 as you can see at https://www.nuget.org/packages/Microsoft.Azure.Management.Sql , so bump to 1.16.0) & update release notes in Microsoft.Azure.Management.Sql.csproj. And bump version in AssemblyInfo.cs.

jaredmoo · 2018-05-18T04:42:12Z

+            // TEST_CSM_ORGID_AUTHENTICATION environment variable in this format then:
+            // SubscriptionId={SubId};ServicePrincipal={clientId};ServicePrincipalSecret={clientSecret};AADTenant={tenantId};Environment={env};HttpRecorderMode=Record;
+            // The below string split and getting the {SubId} should work.
+            this._subscriptionId = Environment.GetEnvironmentVariables()["TEST_CSM_ORGID_AUTHENTICATION"].ToString().Split(';')[0].Split('=')[1];


I think this won't work in test playback, but you can use sqlManagementClient.SubscriptionId instead.

Won't need it since we can just use credential.Id and targetGroup.Id :)

jaredmoo · 2018-05-18T04:44:18Z

+                    JobCredential credential = sqlClient.JobCredentials.CreateOrUpdate(resourceGroup.Name, server.Name, agent.Name, SqlManagementTestUtilities.DefaultLogin, new JobCredential
+                    {
+                        Username = "cloudsa",
+                        Password = "Yukon900!"


You could use

Username = SqlManagementTestUtilities.DefaultLogin, Password = SqlManagementTestUtilities.DefaultPassword,

Never mind, you update below. Can you make this initial credential more fake looking, like just "a" and "b"

jaredmoo · 2018-05-18T04:45:23Z

+                            {
+                                ServerName = "s1",
+                                Type = JobTargetType.SqlServer,
+                                RefreshCredential = FormatCredentialId(resourceGroup.Name, server.Name, agent.Name, credential.Name),


You can just used credential.Id ;)

jaredmoo · 2018-05-18T04:46:15Z

+                    });
+
+
+


nit: excessive whitespace?

jaredmoo · 2018-05-18T04:46:33Z

+                        {
+                            Value = "SELECT 1"
+                        },
+                        TargetGroup = FormatTargetGroupId(resourceGroup.Name, server.Name, agent.Name, targetGroup.Name)


targetGroup.Id

jaredmoo · 2018-05-18T04:51:55Z

Note to SDK team: we also have another SQL feature #4327 coming in at the same time, we will make sure to coordinate between these 2 features. Most likely we can get them completed and published together in the next few days.

… Updated tests based on feedback

johnpaulkee · 2018-05-18T22:42:54Z

-    * ElasticPool.PerDatabaseSettings has replaced ElasticPool.DatabaseDtuMin and ElasticPool.DatabaseDtuMax.
- - Database.MaxSizeBytes is now a long instead of string.
- - LocationCapabilities tree has been changed in order to support capabilities of new vCore-based database and elastic pool editions.
+- Adding support for SQL Database Agent


@jaredmoo Is this new features description too plain? Let me know if you'd like a more detailed one.
I was unsure how detailed to go for a release update.

That is totally fine. Maybe also mention the type names (JobAgent, Job, JobStep, ....) so that it is obvious which types are related to DB agent?

Will update.

dsgouda

Please run msbuild build.proj /t:build /p:Scope=SDs\SqlManagement and commit any changes to the .props file

dsgouda · 2018-05-21T16:38:37Z

-Branch:      master
-Commit:      d08c7f54a125819caaa8c5f553206d1adbae60f9
+GitHub user: johnpaulkee
+Branch:      jobsSdk


Code MUST be generated from a spec in the Azure master branch

We did this in order to isolate this change from other APIs added to readme.md at the same time.

It was just this change to readme: https://github.com/johnpaulkee/azure-rest-api-specs/commit/992e3dd8dfe722697d045458f827e9d554ef6ebb

I'm not sure this is a good strategy. Either create and use a tag in the config file to scope the files you'd like to generate the code for or we could create a whitelisted branch in the repo to coordinate the work before merging with psSdkJson6
@shahabhijeet can you lend some thoughts too?

…s ran msbuild build.proj /t:build /p:Scope=SDs\SqlManagement

johnpaulkee · 2018-05-21T22:12:23Z

@dsgouda I've regenerated from azure master. Note that there will be some included generated SDKs for DatabaseVulnerabilityAssessment, VulnerabilityAssessment, and ShortTermRetentionPolicies that will be added too due to this. FYI @yaakoviyun @dealaus

@jaredmoo I heard from @dsgoudsa that it's fine to add the other SDKs as part of this PR since we can add tests to them later. let me know your thoughts on that.

jaredmoo · 2018-05-22T00:50:45Z

It's fine to include the other features, but the risk to us is that @yaakoviyun & @dealaus will need to add tests before we can release.

jaredmoo · 2018-05-22T19:35:02Z

This PR was merged into #4351 and can be closed,

John Paul Kee added 6 commits May 17, 2018 17:38

Adding .NET sdk

f09e656

Adding tests. Recordings to be placed in after

d12b733

Fixing target group member list initialization bug

cbdd450

Fixing credential and target group id in all tests. Added hacky way t…

28f903a

…o grab subscription id from env variable

Fixing job execution test by allowing all client ips to server

721c1e6

Adding recordings

09fdc91

jaredmoo suggested changes May 18, 2018

View reviewed changes

dsgouda added the Changes Requested label May 18, 2018

Updating .csproj and AssemblyInfo.cs to 1.16.0 and re-recorded tests.…

c5b67c1

… Updated tests based on feedback

johnpaulkee commented May 18, 2018

View reviewed changes

jaredmoo approved these changes May 18, 2018

View reviewed changes

Updating release notes to include the sql db agent type names

8b93e04

dsgouda suggested changes May 21, 2018

View reviewed changes

Regenerated from latest swagger readme.md from azure master as well a…

77ab892

…s ran msbuild build.proj /t:build /p:Scope=SDs\SqlManagement

Renaming to Elastic job agent with re-recorded tests

dbb8d11

jaredmoo mentioned this pull request May 22, 2018

Add SQL ShortTermRetention, VulnerabilityAssessment, and Elastic jobs #4351

Merged

9 tasks

dsgouda merged commit dbb8d11 into Azure:psSdkJson6 May 24, 2018

Conversation

johnpaulkee commented May 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

johnpaulkee commented May 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented May 18, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnpaulkee commented May 21, 2018

Uh oh!

jaredmoo commented May 22, 2018

Uh oh!

jaredmoo commented May 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnpaulkee commented May 18, 2018 •

edited

Loading

johnpaulkee commented May 18, 2018 •

edited

Loading